Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] l10n_br_account_service_type_by_partner: add new module #58

Closed

Conversation

kaynnan
Copy link

@kaynnan kaynnan commented Mar 15, 2024

cc @marcelsavegnago

Módulo para permitir que os parceiros definam um 'service_type' e seus produtos para serem utilizados exclusivamente no processo de faturamento quando estes forem classificados como fornecedores.

@kaynnan kaynnan force-pushed the 14.0-add-l10n_br_account_service_type_by_partner branch 2 times, most recently from ba24534 to 73506cd Compare March 15, 2024 15:57
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.09%. Comparing base (9bb0580) to head (69baece).

Files Patch % Lines
...unt_service_type_by_partner/models/account_move.py 57.14% 5 Missing and 1 partial ⚠️
...ervice_type_by_partner/models/account_move_line.py 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0      #58      +/-   ##
==========================================
- Coverage   89.14%   89.09%   -0.05%     
==========================================
  Files         710      717       +7     
  Lines       27637    27685      +48     
  Branches     3054     3062       +8     
==========================================
+ Hits        24636    24666      +30     
- Misses       2118     2133      +15     
- Partials      883      886       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaynnan kaynnan force-pushed the 14.0-add-l10n_br_account_service_type_by_partner branch 4 times, most recently from da9e011 to 8ac4b06 Compare March 15, 2024 17:17
@marcelsavegnago
Copy link

@kaynnan eu acho que cabe propor na OCA. Esta funcionalidade seria opcional para quem instalar o módulo e a vantagem é que teriamos mais mais gente analisando.

@marcelsavegnago
Copy link

Veja minha revisão e veja acerta esta questão do uso do termo LC para o Service Type.. deixa homogeneo. E ai acho valido propor na OCA.

@kaynnan kaynnan force-pushed the 14.0-add-l10n_br_account_service_type_by_partner branch from 8ac4b06 to 1e6681d Compare March 18, 2024 20:26
@kaynnan kaynnan force-pushed the 14.0-add-l10n_br_account_service_type_by_partner branch from 1e6681d to 69baece Compare March 18, 2024 20:27
@kaynnan
Copy link
Author

kaynnan commented Mar 18, 2024

@marcelsavegnago as demais solicitações foram ajustadas, exceto sobre a tabela, acredito que ela seja essencial para o controle e vinculo entre o service_type ao partner, caso tenha alguma solução sem a utilização dessa tabela, realizo as alterações

@kaynnan kaynnan closed this Apr 17, 2024
@kaynnan kaynnan deleted the 14.0-add-l10n_br_account_service_type_by_partner branch April 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants